Skip to content

8387495: [lworld] Typo in javadoc of jdk/internal/util/ReferencedKeyMap.java#2603

Closed
jaikiran wants to merge 1 commit into
openjdk:lworldfrom
jaikiran:8387495
Closed

8387495: [lworld] Typo in javadoc of jdk/internal/util/ReferencedKeyMap.java#2603
jaikiran wants to merge 1 commit into
openjdk:lworldfrom
jaikiran:8387495

Conversation

@jaikiran

@jaikiran jaikiran commented Jun 30, 2026

Copy link
Copy Markdown
Member

Can I get a review of this doc-only change which fixes a typo in the javadoc of the internal ReferencedKeyMap class?

I borrowed the phrasing from the recent updates we did to the WeakHashMap class.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8387495: [lworld] Typo in javadoc of jdk/internal/util/ReferencedKeyMap.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2603/head:pull/2603
$ git checkout pull/2603

Update a local copy of the PR:
$ git checkout pull/2603
$ git pull https://git.openjdk.org/valhalla.git pull/2603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2603

View PR using the GUI difftool:
$ git pr show -t 2603

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2603.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 30, 2026

Copy link
Copy Markdown

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 30, 2026

Copy link
Copy Markdown

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8387495: [lworld] Typo in javadoc of jdk/internal/util/ReferencedKeyMap.java

Reviewed-by: alanb, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 30, 2026
@mlbridge

mlbridge Bot commented Jun 30, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jul 1, 2026
@jaikiran

jaikiran commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Thank you Alan and Chen for the review.

@jaikiran

jaikiran commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Jul 1, 2026
@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

@jaikiran
Your change (at version e4446a5) is now ready to be sponsored by a Committer.

@liach

liach commented Jul 1, 2026

Copy link
Copy Markdown
Member

/sponsor

@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

Going to push as commit 08ebba3.
Since your change was applied there have been 6 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jul 1, 2026
@openjdk openjdk Bot closed this Jul 1, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 1, 2026
@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

@liach @jaikiran Pushed as commit 08ebba3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8387495 branch July 1, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants